docs icon indicating copy to clipboard operation
docs copied to clipboard

include storage engines in slow query logs and statements summary

Open henrybw opened this issue 6 months ago • 4 comments

First-time contributors' checklist

What is changed, added or deleted? (Required)

Document extra attributes added to identify the storage engine in both the statement summary and slow query log.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • [x] master (the latest development version)
  • [ ] v9.0 (TiDB 9.0 versions)
  • [ ] v8.5 (TiDB 8.5 versions)
  • [ ] v8.4 (TiDB 8.4 versions)
  • [ ] v8.3 (TiDB 8.3 versions)
  • [ ] v8.1 (TiDB 8.1 versions)
  • [ ] v7.5 (TiDB 7.5 versions)
  • [ ] v7.1 (TiDB 7.1 versions)
  • [ ] v6.5 (TiDB 6.5 versions)
  • [ ] v6.1 (TiDB 6.1 versions)
  • [ ] v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

henrybw avatar Jun 12 '25 04:06 henrybw

CLA assistant check
All committers have signed the CLA.

@henrybw Could you please invite a tech reviewer? Thanks!

Oreoxmt avatar Jun 13 '25 02:06 Oreoxmt

@terry1purcell: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Jun 23 '25 23:06 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2025-07-18 03:39:15.173941673 +0000 UTC m=+2835007.897120656: :ballot_box_with_check: agreed by Oreoxmt.
  • 2025-07-18 08:13:40.83625222 +0000 UTC m=+2851473.559431203: :ballot_box_with_check: agreed by qiancai.

ti-chi-bot[bot] avatar Jul 18 '25 08:07 ti-chi-bot[bot]

/approve

Oreoxmt avatar Sep 28 '25 06:09 Oreoxmt

/unhold

Oreoxmt avatar Sep 28 '25 06:09 Oreoxmt

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Sep 28 '25 06:09 ti-chi-bot[bot]