resource control: support more mode for BURSTABLE
First-time contributors' checklist
- [ ] I've signed Contributor License Agreement that's required for repo owners to accept my contribution.
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
- [x] master (the latest development version)
- [ ] v9.0 (TiDB 9.0 versions)
- [ ] v8.5 (TiDB 8.5 versions)
- [ ] v8.4 (TiDB 8.4 versions)
- [ ] v8.3 (TiDB 8.3 versions)
- [ ] v8.1 (TiDB 8.1 versions)
- [ ] v7.5 (TiDB 7.5 versions)
- [ ] v7.1 (TiDB 7.1 versions)
- [ ] v6.5 (TiDB 6.5 versions)
- [ ] v6.1 (TiDB 6.1 versions)
- [ ] v5.4 (TiDB 5.4 versions)
What is the related PR or file link(s)?
- This PR is translated from: https://github.com/pingcap/docs-cn/pull/20020
- Other reference link(s):
Do your changes match any of the following descriptions?
- [ ] Delete files
- [ ] Change aliases
- [ ] Need modification after applied to another branch
- [ ] Might cause conflicts after applied to another branch
@gemini-code-assist[bot]: adding LGTM is restricted to approvers and reviewers in OWNERS files.
In response to this:
Code Review
This pull request updates the documentation to reflect the new modes available for the
BURSTABLEoption in resource groups. The changes are mostly in table outputs and descriptions across several files. Overall, the updates clarify the new functionality. However, there are a few areas that need attention to ensure accuracy and consistency, primarily related to example outputs and a typo.Summary of Findings
- Documentation Accuracy: There's an incorrect row count in the
DESC resource_groups;output ininformation-schema/information-schema-resource-groups.md.- Spelling Error: A typo "UNLIMTED" was found in
sql-statements/sql-statement-create-resource-group.md. It should be "UNLIMITED".- Example Consistency: In
tidb-resource-control-ru-groups.md, an example description refers torg1while the SQL code createsrg4.- Readability: The description of the
BURSTABLEoption is quite long in several files and could be broken down for better readability.- Formatting Consistency: EBNF diagrams in
sql-statement-alter-resource-group.mdandsql-statement-create-resource-group.mdhave inconsistent indentation for the newBURSTABLEoptions.Merge Readiness
The pull request introduces important documentation updates for the
BURSTABLEresource control option. While the changes are largely good, there are a few issues related to accuracy (incorrect command output, typo) and consistency (example naming) that should be addressed before merging. Addressing these will improve the clarity and correctness of the documentation. I am unable to approve pull requests, so please ensure these changes are reviewed and approved by a maintainer.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[LGTM Timeline notifier]
Timeline:
This PR is ready for merging.
/unhold
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lilin90
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [lilin90]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/hold