pingcap
add tikv compaction and flow control setting
First-time contributors' checklist
- [x] I've signed Contributor License Agreement that's required for repo owners to accept my contribution.
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
- [x] master (the latest development version)
- [x] v9.0 (TiDB 9.0 versions)
- [x] v8.5 (TiDB 8.5 versions)
- [x] v8.4 (TiDB 8.4 versions)
- [ ] v8.3 (TiDB 8.3 versions)
- [x] v8.1 (TiDB 8.1 versions)
- [ ] v7.5 (TiDB 7.5 versions)
- [ ] v7.1 (TiDB 7.1 versions)
- [ ] v6.5 (TiDB 6.5 versions)
- [ ] v6.1 (TiDB 6.1 versions)
- [ ] v5.4 (TiDB 5.4 versions)
What is the related PR or file link(s)?
- This PR is translated from:
- Other reference link(s):
Do your changes match any of the following descriptions?
- [ ] Delete files
- [ ] Change aliases
- [ ] Need modification after applied to another branch
- [ ] Might cause conflicts after applied to another branch
Hi @dbsid. Thanks for your PR.
I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![ti-chi-bot[bot] avatar](https://avatars.githubusercontent.com/in/214286?v=4 "Published by a pub.dev verified publisher"){kind=small}
@gemini-code-assist[bot]: adding LGTM is restricted to approvers and reviewers in OWNERS files.
In response to this:
Code Review
This pull request adds valuable information about tuning TiKV's compaction and flow control settings for write-intensive workloads. The added configuration examples and explanations are clear and directly applicable. I've identified a few minor areas for improvement related to documentation style and a typo.
Summary of Findings
- Documentation Style: The heading 'Recommended Configuration Adjustments for Write-Intensive Workloads' does not follow the recommended sentence case convention for headings[^1].
- Typo: There is a typo ('flow controlss') in the final note block[^2].
Merge Readiness
The changes provide valuable information and are generally well-written. The identified issues are minor documentation style points and a typo. I recommend addressing these low-severity issues before merging to maintain documentation quality. I am unable to approve this pull request; please have other reviewers approve it before merging.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@shaoxiqian: adding LGTM is restricted to approvers and reviewers in OWNERS files.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@shaoxiqian: adding LGTM is restricted to approvers and reviewers in OWNERS files.
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Yui-Song: adding LGTM is restricted to approvers and reviewers in OWNERS files.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@zhangjinpeng87: adding LGTM is restricted to approvers and reviewers in OWNERS files.
In response to this:
LGTM for TiKV changes.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[LGTM Timeline notifier]
Timeline:
2025-07-31 07:17:18.518833173 +0000 UTC m=+162051.204103398: :ballot_box_with_check: agreed by hfxsd.
@hfxsd: Your lgtm message is repeated, so it is ignored.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hfxsd
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [hfxsd]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
In response to a cherrypick label: new pull request created to branch release-8.1: #21500.
But this PR has conflicts, please resolve them!
In response to a cherrypick label: new pull request created to branch release-8.5: #21501.