docs icon indicating copy to clipboard operation
docs copied to clipboard

Fix wording to reflect poor performance of initial query before optimization

Open aquarapid opened this issue 8 months ago • 4 comments

What is changed, added or deleted? (Required)

Fix wording in the explain walkthrough, the current working seems to imply that the initial performance is good (which it is not). The rest of the walkthrough is to improve the performance, so the changed wording seems more correct.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • [x] master (the latest development version)
  • [ ] v9.0 (TiDB 9.0 versions)
  • [ ] v8.5 (TiDB 8.5 versions)
  • [ ] v8.4 (TiDB 8.4 versions)
  • [ ] v8.3 (TiDB 8.3 versions)
  • [ ] v8.1 (TiDB 8.1 versions)
  • [ ] v7.5 (TiDB 7.5 versions)
  • [ ] v7.1 (TiDB 7.1 versions)
  • [ ] v6.5 (TiDB 6.5 versions)
  • [ ] v6.1 (TiDB 6.1 versions)
  • [ ] v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

see diff

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

aquarapid avatar Apr 23 '25 05:04 aquarapid

Hi @aquarapid. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Apr 23 '25 05:04 ti-chi-bot[bot]

@time-and-fate: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Apr 24 '25 04:04 ti-chi-bot[bot]

/ok-to-test

qiancai avatar Jun 20 '25 06:06 qiancai

/approve

qiancai avatar Jun 27 '25 02:06 qiancai

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jun 27 '25 02:06 ti-chi-bot[bot]

In response to a cherrypick label: new pull request created to branch release-8.5: #21267.

ti-chi-bot avatar Jun 27 '25 02:06 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-8.1: #21268.

ti-chi-bot avatar Jun 27 '25 02:06 ti-chi-bot