docs icon indicating copy to clipboard operation
docs copied to clipboard

system tables: add a note for DATA_LENGTH, INDEX_LENGTH, and TABLE_SIZE

Open qiancai opened this issue 1 year ago • 5 comments

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add a note for DATA_LENGTH, INDEX_LENGTH, and TABLE_SIZE to explain they are logical estimates instead of actual physical sizes.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • [x] master (the latest development version)
  • [x] v8.5 (TiDB 8.5 versions)
  • [ ] v8.4 (TiDB 8.4 versions)
  • [ ] v8.3 (TiDB 8.3 versions)
  • [ ] v8.2 (TiDB 8.2 versions)
  • [x] v8.1 (TiDB 8.1 versions)
  • [ ] v7.5 (TiDB 7.5 versions)
  • [ ] v7.1 (TiDB 7.1 versions)
  • [ ] v6.5 (TiDB 6.5 versions)
  • [ ] v6.1 (TiDB 6.1 versions)
  • [ ] v5.4 (TiDB 5.4 versions)
  • [ ] v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

qiancai avatar Nov 13 '24 05:11 qiancai

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Nov 13 '24 05:11 ti-chi-bot[bot]

@mjonss I assume that partitioning and global index work as expected when it comes to the storage size explained here?

dveeden avatar Nov 13 '24 06:11 dveeden

TIKV_REGION_STATUS seems to depend on Prometheus being available. However this isn't noted on https://docs.pingcap.com/tidb/stable/information-schema-tikv-region-status

The result is that size calculation would fail with this error:

ERROR 1105 (HY000): query metric error: [domain:9009]Prometheus address is not set in PD and etcd

If a custom Prometheus is used then the address might not be configured correctly in pd/etcd. If there is no Prometheus we may want to see if there are any alternatives available

dveeden avatar Nov 13 '24 07:11 dveeden

@AilinKid: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Nov 14 '24 06:11 ti-chi-bot[bot]

Removed the needs-cherry-pick-release-8.4 label because the v8.4 docs have been archived at https://docs-archive.pingcap.com/tidb/v8.4 and will no longer receive new updates.

qiancai avatar Jul 11 '25 07:07 qiancai