docs icon indicating copy to clipboard operation
docs copied to clipboard

Update timezone docs

Open dveeden opened this issue 1 year ago • 2 comments

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • [x] master (the latest development version)
  • [ ] v8.2 (TiDB 8.2 versions)
  • [x] v8.1 (TiDB 8.1 versions)
  • [ ] v8.0 (TiDB 8.0 versions)
  • [ ] v7.6 (TiDB 7.6 versions)
  • [ ] v7.5 (TiDB 7.5 versions)
  • [ ] v7.1 (TiDB 7.1 versions)
  • [ ] v6.5 (TiDB 6.5 versions)
  • [ ] v6.1 (TiDB 6.1 versions)
  • [ ] v5.4 (TiDB 5.4 versions)
  • [ ] v5.3 (TiDB 5.3 versions)
  • [ ] v5.2 (TiDB 5.2 versions)
  • [ ] v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

dveeden avatar Oct 10 '24 07:10 dveeden

@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM with some suggestions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Oct 21 '24 13:10 ti-chi-bot[bot]

@mjonss should we mention weird things like the right/ zones (e.g. right/Universal) and posix/ (e.g. posix/Chile/EasterIsland) ? Or should we remove support for them maybe?

TiDB

mysql-8.0.11-TiDB-v8.4.0-alpha-445-g6eed1cd7bd> SET time_zone = 'posix/Chile/EasterIsland';
Query OK, 0 rows affected (0.00 sec)

mysql-8.0.11-TiDB-v8.4.0-alpha-445-g6eed1cd7bd> SET time_zone = 'right/Universal';
Query OK, 0 rows affected (0.00 sec)

MySQL

mysql-9.1.0> SET time_zone = 'posix/Chile/EasterIsland';
ERROR 1298 (HY000): Unknown or incorrect time zone: 'posix/Chile/EasterIsland'
mysql-9.1.0> SET time_zone = 'right/Universal';
ERROR 1298 (HY000): Unknown or incorrect time zone: 'right/Universal'

dveeden avatar Oct 23 '24 08:10 dveeden

@mjonss should we mention weird things like the right/ zones (e.g. right/Universal) and posix/ (e.g. posix/Chile/EasterIsland) ? Or should we remove support for them maybe? ...

I think we don't need to mention it, since it is platform/OS/installation dependent, I think we can ignore it and just keep what golang implements. As long as we are MySQL compatible too :)

mjonss avatar Oct 29 '24 09:10 mjonss

[LGTM Timeline notifier]

Timeline:

  • 2024-11-11 09:06:36.952844613 +0000 UTC m=+260759.143713611: :ballot_box_with_check: agreed by qiancai.
  • 2024-12-04 14:50:43.216884669 +0000 UTC m=+1252830.836539180: :ballot_box_with_check: agreed by hfxsd.

ti-chi-bot[bot] avatar Dec 04 '24 14:12 ti-chi-bot[bot]

/approve

qiancai avatar Dec 05 '24 06:12 qiancai

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Dec 05 '24 06:12 ti-chi-bot[bot]

In response to a cherrypick label: new pull request created to branch release-8.5: #19587.

ti-chi-bot avatar Dec 05 '24 06:12 ti-chi-bot