docs icon indicating copy to clipboard operation
docs copied to clipboard

SELECT: Update EBNF for partitioning

Open dveeden opened this issue 1 year ago • 2 comments

What is changed, added or deleted? (Required)

Update EBNF for:

  • Partition selection: SELECT * FROM t1 PARTITION (p0);
  • Joins

Use https://kennytm.github.io/website-docs/dist/ for previewing the EBNF

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • [x] master (the latest development version)
  • [ ] v8.2 (TiDB 8.2 versions)
  • [ ] v8.1 (TiDB 8.1 versions)
  • [ ] v8.0 (TiDB 8.0 versions)
  • [ ] v7.6 (TiDB 7.6 versions)
  • [ ] v7.5 (TiDB 7.5 versions)
  • [ ] v7.1 (TiDB 7.1 versions)
  • [ ] v6.5 (TiDB 6.5 versions)
  • [ ] v6.1 (TiDB 6.1 versions)
  • [ ] v5.4 (TiDB 5.4 versions)
  • [ ] v5.3 (TiDB 5.3 versions)
  • [ ] v5.2 (TiDB 5.2 versions)
  • [ ] v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

dveeden avatar Jun 21 '24 09:06 dveeden

@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Approved with some requests and questions :)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Jul 02 '24 13:07 ti-chi-bot[bot]

hi @kennytm, would you please take a look at this PR again and approve it if no problem? Thanks.

qiancai avatar Aug 23 '24 08:08 qiancai

@qiancai No the generated EBNF is still wrong.

image

kennytm avatar Aug 23 '24 15:08 kennytm

@qiancai No the generated EBNF is still wrong.

image

Fixed in 05ff289c15343ead941d54dfd15cc32040eb1054: image

dveeden avatar Aug 26 '24 07:08 dveeden

@qiancai No the generated EBNF is still wrong. image

Fixed in 05ff289: image

@kennytm PTAL. Thanks.

qiancai avatar Aug 26 '24 08:08 qiancai

@kennytm: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Aug 26 '24 09:08 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-08-28 07:00:13.125494077 +0000 UTC m=+940008.259944198: :ballot_box_with_check: agreed by qiancai.

ti-chi-bot[bot] avatar Aug 28 '24 07:08 ti-chi-bot[bot]

/approve

qiancai avatar Aug 28 '24 07:08 qiancai

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Aug 28 '24 07:08 ti-chi-bot[bot]