docs icon indicating copy to clipboard operation
docs copied to clipboard

Add sql mode format restrictions to expr in ticdc filter

Open hongyunyan opened this issue 1 year ago • 4 comments

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • [x] master (the latest development version)
  • [x] v8.0 (TiDB 8.0 versions)
  • [ ] v7.6 (TiDB 7.6 versions)
  • [ ] v7.5 (TiDB 7.5 versions)
  • [ ] v7.4 (TiDB 7.4 versions)
  • [ ] v7.1 (TiDB 7.1 versions)
  • [ ] v6.5 (TiDB 6.5 versions)
  • [ ] v6.1 (TiDB 6.1 versions)
  • [ ] v5.4 (TiDB 5.4 versions)
  • [ ] v5.3 (TiDB 5.3 versions)
  • [ ] v5.2 (TiDB 5.2 versions)
  • [ ] v5.1 (TiDB 5.1 versions)
  • [ ] v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from: https://github.com/pingcap/docs-cn/pull/16689
  • Other reference link(s): https://github.com/pingcap/tiflow/pull/10644

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

hongyunyan avatar Feb 28 '24 06:02 hongyunyan

/cc @CharlesCheung96 @flowbehappy

hongyunyan avatar Feb 28 '24 06:02 hongyunyan

@asddongmen: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Mar 08 '24 01:03 ti-chi-bot[bot]

I updated this PR in https://github.com/pingcap/docs/pull/16626/commits/02f86e0e773b91c17ae56ea88a4e573bdb6ee33d according to @qiancai's comments for https://github.com/pingcap/docs-cn/pull/16689.

lilin90 avatar Mar 11 '24 08:03 lilin90

[LGTM Timeline notifier]

Timeline:

  • 2024-03-07 08:21:19.415736708 +0000 UTC m=+328106.437983097: :ballot_box_with_check: agreed by lilin90.
  • 2024-03-12 06:27:21.180984268 +0000 UTC m=+753268.203230649: :ballot_box_with_check: agreed by qiancai.

ti-chi-bot[bot] avatar Mar 12 '24 06:03 ti-chi-bot[bot]

/approve

lilin90 avatar Mar 19 '24 03:03 lilin90

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Mar 19 '24 03:03 ti-chi-bot[bot]