docs icon indicating copy to clipboard operation
docs copied to clipboard

cdc: fix index-value dispatcher config typo

Open kennytm opened this issue 1 year ago • 2 comments

What is changed, added or deleted? (Required)

In this section https://docs.pingcap.com/tidb/stable/ticdc-sink-to-kafka#partition-dispatchers, the dispatcher config key index-name should have been index according to the actual implementation in pingcap/tiflow#9825.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • [x] master (the latest development version)
  • [x] v7.6 (TiDB 7.6 versions)
  • [x] v7.5 (TiDB 7.5 versions)
  • [ ] v7.4 (TiDB 7.4 versions)
  • [ ] v7.3 (TiDB 7.3 versions)
  • [ ] v7.1 (TiDB 7.1 versions)
  • [ ] v6.5 (TiDB 6.5 versions)
  • [ ] v6.1 (TiDB 6.1 versions)
  • [ ] v5.4 (TiDB 5.4 versions)
  • [ ] v5.3 (TiDB 5.3 versions)
  • [ ] v5.2 (TiDB 5.2 versions)
  • [ ] v5.1 (TiDB 5.1 versions)
  • [ ] v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s): #15278

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

kennytm avatar Jan 30 '24 18:01 kennytm

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from oreoxmt. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jan 31 '24 07:01 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-01-31 08:45:29.114659898 +0000 UTC m=+1555170.678957602: :ballot_box_with_check: agreed by Oreoxmt.

ti-chi-bot[bot] avatar Jan 31 '24 08:01 ti-chi-bot[bot]

@3AceShowHand @nongfushanquan PTAL

Oreoxmt avatar Mar 26 '24 01:03 Oreoxmt

@Oreoxmt: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Apr 02 '24 08:04 ti-chi-bot[bot]

/cc @CharlesCheung96

Oreoxmt avatar Jun 12 '24 10:06 Oreoxmt

[LGTM Timeline notifier]

Timeline:

  • 2024-01-31 08:45:29.114659898 +0000 UTC m=+1555170.678957602: :ballot_box_with_check: agreed by Oreoxmt.
  • 2024-06-12 10:08:33.220934819 +0000 UTC m=+545667.274246740: :ballot_box_with_check: agreed by qiancai.

ti-chi-bot[bot] avatar Jun 12 '24 10:06 ti-chi-bot[bot]

/approve

Oreoxmt avatar Jun 13 '24 06:06 Oreoxmt

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jun 13 '24 06:06 ti-chi-bot[bot]

In response to a cherrypick label: new pull request created to branch release-7.6: #17885.

ti-chi-bot avatar Jun 13 '24 07:06 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-8.0: #17886.

ti-chi-bot avatar Jun 13 '24 07:06 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-8.1: #17887.

ti-chi-bot avatar Jun 13 '24 07:06 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-7.5: #17888.

ti-chi-bot avatar Jun 13 '24 07:06 ti-chi-bot