docs icon indicating copy to clipboard operation
docs copied to clipboard

Use right-alighed markdown to compare numbers in min-blob-size

Open yahonda opened this issue 1 year ago • 2 comments

What is changed, added or deleted? (Required)

This pull request uses the right-alighed markdown to compare numbers in min-blob-size easily. See https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/organizing-information-with-tables for the detail.

IMO, it is easy to compare right-alined numbers than left-aligned ones.

Preview with this commit

Screenshot 2024-01-26 at 11 45 07

Preview without this commit

Screenshot 2024-01-26 at 11 45 19

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • [x] master (the latest development version)
  • [ ] v7.6 (TiDB 7.6 versions)
  • [ ] v7.5 (TiDB 7.5 versions)
  • [ ] v7.4 (TiDB 7.4 versions)
  • [ ] v7.3 (TiDB 7.3 versions)
  • [ ] v7.1 (TiDB 7.1 versions)
  • [ ] v6.5 (TiDB 6.5 versions)
  • [ ] v6.1 (TiDB 6.1 versions)
  • [ ] v5.4 (TiDB 5.4 versions)
  • [ ] v5.3 (TiDB 5.3 versions)
  • [ ] v5.2 (TiDB 5.2 versions)
  • [ ] v5.1 (TiDB 5.1 versions)
  • [ ] v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

yahonda avatar Jan 26 '24 02:01 yahonda

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign lilin90 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jan 26 '24 02:01 ti-chi-bot[bot]

Preview link: https://pingcap-docsite-preview-git-preview-pingcapdocs16326-oreoxmt.vercel.app/tidb/dev/titan-overview#impact-of-min-blob-size-on-performance

@yahonda Thanks for your contribution. However, it seems our website currently does not support this syntax, causing the table to not be right-aligned:

image

@Yuiham Would you please help check? Thanks.

Oreoxmt avatar Jan 26 '24 03:01 Oreoxmt

[LGTM Timeline notifier]

Timeline:

  • 2024-05-28 05:54:38.669939608 +0000 UTC m=+2755832.427075176: :ballot_box_with_check: agreed by qiancai.

ti-chi-bot[bot] avatar May 28 '24 05:05 ti-chi-bot[bot]