docs icon indicating copy to clipboard operation
docs copied to clipboard

Clarify swap descriptions

Open hfxsd opened this issue 1 year ago • 6 comments

What is changed, added or deleted? (Required)

Clarify confusing descriptions for disabling system swap

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • [x] master (the latest development version)
  • [x] v7.3 (TiDB 7.3 versions)
  • [x] v7.2 (TiDB 7.2 versions)
  • [x] v7.1 (TiDB 7.1 versions)
  • [ ] v7.0 (TiDB 7.0 versions)
  • [ ] v6.5 (TiDB 6.5 versions)
  • [ ] v6.1 (TiDB 6.1 versions)
  • [ ] v5.4 (TiDB 5.4 versions)
  • [ ] v5.3 (TiDB 5.3 versions)
  • [ ] v5.2 (TiDB 5.2 versions)
  • [ ] v5.1 (TiDB 5.1 versions)
  • [ ] v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from: https://github.com/pingcap/docs-cn/pull/14662
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

hfxsd avatar Aug 10 '23 00:08 hfxsd

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from hfxsd. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Aug 10 '23 00:08 ti-chi-bot[bot]

/verify

hfxsd avatar Aug 10 '23 01:08 hfxsd

@bb7133: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Aug 10 '23 01:08 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2023-08-10 06:50:38.130893406 +0000 UTC m=+181802.679909378: :ballot_box_with_check: agreed by dveeden.

ti-chi-bot[bot] avatar Aug 10 '23 06:08 ti-chi-bot[bot]

Removed the needs-cherry-pick-release-7.2 label because the v7.2 docs have been archived at https://docs-archive.pingcap.com/tidb/v7.2 and will no longer receive new updates.

qiancai avatar Oct 20 '23 07:10 qiancai

Removed the needs-cherry-pick-release-7.3 label because the v7.3 docs have been archived at https://docs-archive.pingcap.com/tidb/v7.3 and will no longer receive new updates.

qiancai avatar Feb 02 '24 06:02 qiancai