docs icon indicating copy to clipboard operation
docs copied to clipboard

Update release-6.3.0.md

Open solotzg opened this issue 3 years ago • 5 comments

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • [ ] master (the latest development version)
  • [ ] v6.4 (TiDB 6.4 versions)
  • [x] v6.3 (TiDB 6.3 versions)
  • [ ] v6.1 (TiDB 6.1 versions)
  • [ ] v5.4 (TiDB 5.4 versions)
  • [ ] v5.3 (TiDB 5.3 versions)
  • [ ] v5.2 (TiDB 5.2 versions)
  • [ ] v5.1 (TiDB 5.1 versions)
  • [ ] v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

solotzg avatar Oct 08 '22 00:10 solotzg

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Oct 08 '22 00:10 ti-chi-bot

This note seems an open issue found in 6.3, not an improvement made in 6.3. I guess we will fix it in future versions. How about we adding the bug fix to the release notes of the future patch and minor releases?

shichun-0415 avatar Oct 08 '22 02:10 shichun-0415

This note seems an open issue found in 6.3, not an improvement made in 6.3. I guess we will fix it in future versions. How about we adding the bug fix to the release notes of the future patch and minor releases?

Issue https://github.com/pingcap/tiflash/issues/6075 is caused by that someone use a too old platform to deploy TiFlash v6.3.0. We need to make an explanation that TiFlash reqiures some CPU instruction sets since v6.3.0.

solotzg avatar Oct 08 '22 04:10 solotzg

We need to make an explanation that TiFlash reqiures some CPU instruction sets since v6.3.0.

Let's put the statement in Compatibility Changes > Others. https://github.com/pingcap/docs/pull/10631/files#diff-577672dd123c42d722caad525849ff7ee636eab7a8ca14597c7e674a93cbc04fR246 image

shichun-0415 avatar Oct 08 '22 05:10 shichun-0415

We need to make an explanation that TiFlash reqiures some CPU instruction sets since v6.3.0.

Let's put the statement in Compatibility Changes > Others.

Done.

solotzg avatar Oct 08 '22 06:10 solotzg

/merge

solotzg avatar Oct 09 '22 03:10 solotzg

@solotzg: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Oct 09 '22 03:10 ti-chi-bot

/status LGT2

shichun-0415 avatar Oct 09 '22 03:10 shichun-0415

/merge

shichun-0415 avatar Oct 09 '22 03:10 shichun-0415

This pull request has been accepted and is ready to merge.

Commit hash: 6eeadcc91dfe82281c24f65b63f944d7dd2635c2

ti-chi-bot avatar Oct 09 '22 03:10 ti-chi-bot

In response to a cherrypick label: new pull request created: #10674.

ti-chi-bot avatar Oct 09 '22 04:10 ti-chi-bot