docs-cn
docs-cn copied to clipboard
refactor/improve clarity: refactored and added more details about duplicate detection of tidb-lightning
First-time contributors' checklist
- [x] I've signed Contributor License Agreement that's required for repo owners to accept my contribution.
What is changed, added or deleted? (Required)
之前的冲突检测杂糅在backend导入模式的配置介绍中,并且比较简略,不是太清晰。我结合现有的内容,创建了一个新的页面解释冲突检测,加入了详细的例子以及更多关于冲突检测的细节。
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
- [x] master (the latest development version)
- [ ] v6.1 (TiDB 6.1 versions)
- [ ] v6.0 (TiDB 6.0 versions)
- [ ] v5.4 (TiDB 5.4 versions)
- [ ] v5.3 (TiDB 5.3 versions)
- [ ] v5.2 (TiDB 5.2 versions)
- [ ] v5.1 (TiDB 5.1 versions)
- [ ] v5.0 (TiDB 5.0 versions)
- [ ] v4.0 (TiDB 4.0 versions)
What is the related PR or file link(s)?
- This PR is translated from:
- Other reference link(s):
Do your changes match any of the following descriptions?
- [ ] Delete files
- [ ] Change aliases
- [ ] Need modification after applied to another branch
- [ ] Might cause conflicts after applied to another branch
[REVIEW NOTIFICATION]
This pull request has not been approved.
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer
in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer
in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Welcome @nova-xu!
It looks like this is your first PR to pingcap/docs-cn 🎉.
I'm the bot to help you request reviewers, add labels and more, See available commands.
We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to pingcap/docs-cn. :smiley:
@sunzhaoyang 您好,我已经根据您的feedback做了相应的修改,麻烦您帮我看看还有没有什么需要改进的地方。多谢!
LGTM 不过我建议 TOC 先不加,等重构的 PR 合并之后我再做一些合并的处理 cc @ran-huang
/cc @gozssky
@nova-xu please fix the error of " jenkins-docs-cn/verify "
@ran-huang we have to merge this article with current duplicate detection document
@ran-huang we have to merge this article with current duplicate detection document
@sunzhaoyang You mean merge with this doc?
@sunzhaoyang I fixed the previous manual line break error, but Jenkins still failed for another reason. I read the detailed information, but I'm not sure if this means my doc didn't pass the markdownlint check.
/rebase
@nova-xu Hi, sorry for the delayed response. Could you please merge commits from the master branch so we can proceed with the review?
/rebase