docs-cn icon indicating copy to clipboard operation
docs-cn copied to clipboard

optimizer hints: add notes for how to specify the table name in hints

Open winoros opened this issue 3 years ago • 8 comments

First-time contributors' checklist

What is changed, added or deleted? (Required)

It's a little against intuition when we are specifying a table in the optimizer hints. So we add some notes to tell the user how to use it.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • [x] master (the latest development version)
  • [x] v5.4 (TiDB 5.4 versions)
  • [x] v5.3 (TiDB 5.3 versions)
  • [x] v5.2 (TiDB 5.2 versions)
  • [x] v5.1 (TiDB 5.1 versions)
  • [x] v5.0 (TiDB 5.0 versions)
  • [ ] v4.0 (TiDB 4.0 versions)
  • [ ] v3.1 (TiDB 3.1 versions)
  • [ ] v3.0 (TiDB 3.0 versions)
  • [ ] v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

winoros avatar Feb 08 '22 08:02 winoros

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Feb 08 '22 08:02 ti-chi-bot

what about English version?

I'll translate the approved Chinese version into English. First, let's have this PR approved.

TomShawn avatar Feb 09 '22 03:02 TomShawn

Let's do a review and merge into branch, thx. @TomShawn

yiwen92 avatar Mar 14 '22 09:03 yiwen92

@winoros Please take a look at the comments above and address them. Thanks~

TomShawn avatar Apr 14 '22 03:04 TomShawn

Removed the needs-cherry-pick-release-6.3 label because the v6.3 docs have been archived at https://docs-archive.pingcap.com/zh/tidb/v6.3 and will no longer receive new updates.

qiancai avatar Feb 24 '23 11:02 qiancai

Removed the needs-cherry-pick-release-6.4 label because the v6.4 docs have been archived at https://docs-archive.pingcap.com/zh/tidb/v6.4 and will no longer receive new updates.

qiancai avatar Apr 06 '23 07:04 qiancai

Removed the needs-cherry-pick-release-6.6 label because the v6.6 docs have been archived at https://docs-archive.pingcap.com/zh/tidb/v6.6 and will no longer receive new updates.

qiancai avatar Jul 07 '23 06:07 qiancai

@winoros: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify 413f62cc88c90b39af88af7f04d83efc928c875a link true /test pull-verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Jan 26 '24 11:01 ti-chi-bot[bot]