docs-cn icon indicating copy to clipboard operation
docs-cn copied to clipboard

Translate TiCDC Craft binary protocol document from English

Open humengyu2012 opened this issue 3 years ago • 14 comments

Signed-off-by: Mengyu Hu [email protected]

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add a document about the TiCDC Craft binary protocol.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • [x] master (the latest development version)
  • [x] v5.2 (TiDB 5.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from: https://github.com/pingcap/docs/pull/5293
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

humengyu2012 avatar Nov 18 '21 11:11 humengyu2012

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Nov 18 '21 11:11 ti-chi-bot

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 18 '21 11:11 CLAassistant

This document is translated from https://github.com/pingcap/docs/pull/5293

sunxiaoguang avatar Nov 18 '21 14:11 sunxiaoguang

close #7118

sunxiaoguang avatar Nov 18 '21 14:11 sunxiaoguang

@humengyu2012 Please:

  • Sign the CLA as indicated by https://github.com/pingcap/docs-cn/pull/7547#issuecomment-972788594
  • Keep the PR description template AS IT IS.
  • Invite tech reviews.

Thanks~

TomShawn avatar Nov 19 '21 06:11 TomShawn

@sunxiaoguang: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Nov 28 '21 13:11 ti-chi-bot

Well done! @humengyu2012

@TomShawn I reviewed the translation and it looks good to me.

sunxiaoguang avatar Nov 28 '21 13:11 sunxiaoguang

Well done! @humengyu2012

@TomShawn I reviewed the translation and it looks good to me.

Could you please take a look? Thanks~

TomShawn avatar Dec 02 '21 11:12 TomShawn

Well done! @humengyu2012 @TomShawn I reviewed the translation and it looks good to me.

Could you please take a look? Thanks~

I reviewed it last time. It LTGM.

sunxiaoguang avatar Dec 02 '21 14:12 sunxiaoguang

@sunxiaoguang: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Dec 02 '21 14:12 ti-chi-bot

Well done! @humengyu2012 @TomShawn I reviewed the translation and it looks good to me.

Could you please take a look? Thanks~

I reviewed it last time. It LTGM.

Oh sorry, I forgot to @hfxsd😂.

TomShawn avatar Dec 03 '21 02:12 TomShawn

Removed the needs-cherry-pick-release-6.4 label because the v6.4 docs have been archived at https://docs-archive.pingcap.com/zh/tidb/v6.4 and will no longer receive new updates.

qiancai avatar Apr 06 '23 07:04 qiancai

Removed the needs-cherry-pick-release-6.6 label because the v6.6 docs have been archived at https://docs-archive.pingcap.com/zh/tidb/v6.6 and will no longer receive new updates.

qiancai avatar Jul 07 '23 06:07 qiancai

@humengyu2012: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify 4a2adf883e069d21eebe8d92cda6ba0cd750a280 link true /test pull-verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Jan 26 '24 11:01 ti-chi-bot[bot]