docs-cn icon indicating copy to clipboard operation
docs-cn copied to clipboard

Correct some configs' notes

Open v01dstar opened this issue 1 year ago • 2 comments

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • [x] master (the latest development version)
  • [x] v8.4 (TiDB 8.4 versions)
  • [x] v8.3 (TiDB 8.3 versions)
  • [x] v8.2 (TiDB 8.2 versions)
  • [x] v8.1 (TiDB 8.1 versions)
  • [x] v7.5 (TiDB 7.5 versions)
  • [x] v7.1 (TiDB 7.1 versions)
  • [x] v6.5 (TiDB 6.5 versions)
  • [x] v6.1 (TiDB 6.1 versions)
  • [ ] v5.4 (TiDB 5.4 versions)
  • [ ] v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

v01dstar avatar Oct 10 '24 21:10 v01dstar

Hi @v01dstar. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Oct 10 '24 21:10 ti-chi-bot[bot]

/ok-to-test

qiancai avatar Oct 24 '24 03:10 qiancai

@v01dstar, please involve a tech reviewer for this PR. Thanks.

qiancai avatar Oct 24 '24 03:10 qiancai

@LykxSassinator: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Oct 31 '24 02:10 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-11-04 02:22:47.306649444 +0000 UTC m=+834880.145804990: :ballot_box_with_check: agreed by qiancai.

ti-chi-bot[bot] avatar Nov 04 '24 02:11 ti-chi-bot[bot]

In https://docs.pingcap.com/zh/tidb/v6.1/tikv-configuration-file, the config notes are not included for raft-max-size-per-msg and raft-max-inflight-msgs, so the "needs-cherry-pick-release-6.1" label can be removed for this docs-cn PR.

qiancai avatar Nov 04 '24 06:11 qiancai

/approve

qiancai avatar Nov 04 '24 07:11 qiancai

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Nov 04 '24 07:11 ti-chi-bot[bot]

In response to a cherrypick label: new pull request created to branch release-8.3: #18998.

ti-chi-bot avatar Nov 04 '24 07:11 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-8.4: #18999.

ti-chi-bot avatar Nov 04 '24 07:11 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-6.5: #19000.

ti-chi-bot avatar Nov 04 '24 07:11 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-7.1: #19001.

ti-chi-bot avatar Nov 04 '24 07:11 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-7.5: #19002.

ti-chi-bot avatar Nov 04 '24 07:11 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-8.1: #19003.

ti-chi-bot avatar Nov 04 '24 07:11 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-8.2: #19004.

ti-chi-bot avatar Nov 04 '24 07:11 ti-chi-bot