docs-cn icon indicating copy to clipboard operation
docs-cn copied to clipboard

Spm fix hint issue

Open songrijie opened this issue 1 year ago • 2 comments

What is changed, added or deleted? (Required)

  • fix hint issue in one example which doesn't work.
  • remove one rewriting suggestion while it's not equivalent to original query.
  • make a few examples more comprehensible by replacing the obscure schemas with demo from "bookshop".

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • [x] master (the latest development version)
  • [x] v8.4 (TiDB 8.4 versions)
  • [x] v8.3 (TiDB 8.3 versions)
  • [x] v8.2 (TiDB 8.2 versions)
  • [x] v8.1 (TiDB 8.1 versions)
  • [ ] v7.5 (TiDB 7.5 versions)
  • [ ] v7.1 (TiDB 7.1 versions)
  • [ ] v6.5 (TiDB 6.5 versions)
  • [ ] v6.1 (TiDB 6.1 versions)
  • [ ] v5.4 (TiDB 5.4 versions)
  • [ ] v5.3 (TiDB 5.3 versions))

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

songrijie avatar Sep 04 '24 11:09 songrijie

@elsa0520: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Sep 05 '24 02:09 ti-chi-bot[bot]

Removed the needs-cherry-pick-release-8.2 label because the v8.2 docs have been archived at https://docs-archive.pingcap.com/zh/tidb/v8.2 and will no longer receive new updates.

qiancai avatar Dec 30 '24 09:12 qiancai

[LGTM Timeline notifier]

Timeline:

  • 2024-12-20 01:43:34.95455586 +0000 UTC m=+1180405.043358401: :ballot_box_with_check: agreed by hfxsd.
  • 2025-01-07 03:13:37.613120997 +0000 UTC m=+236960.901952702: :ballot_box_with_check: agreed by qiancai.

ti-chi-bot[bot] avatar Jan 07 '25 03:01 ti-chi-bot[bot]

/approve

hfxsd avatar Jan 07 '25 03:01 hfxsd

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jan 07 '25 03:01 ti-chi-bot[bot]

In response to a cherrypick label: new pull request created to branch release-8.3: #19481.

ti-chi-bot avatar Jan 07 '25 03:01 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-8.5: #19482.

ti-chi-bot avatar Jan 07 '25 03:01 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-8.4: #19483.

ti-chi-bot avatar Jan 07 '25 03:01 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-8.1: #19484.

ti-chi-bot avatar Jan 07 '25 03:01 ti-chi-bot