docs-cn icon indicating copy to clipboard operation
docs-cn copied to clipboard

ticdc: clarify that you don't escape the whole URL but just the parameters

Open kennytm opened this issue 1 year ago • 4 comments

What is changed, added or deleted? (Required)

Clarify the wording on what needs to be URI-Encoded.

Some customer reading this note thought they need to pass the Sink URI like this:

--sink-uri='mysql%3A%2F%2Froot%3ATidb%40123456%40127.0.0.1%3A3306%2F'

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • [x] master (the latest development version)
  • [x] v8.1 (TiDB 8.1 versions)
  • [x] v8.0 (TiDB 8.0 versions)
  • [x] v7.6 (TiDB 7.6 versions)
  • [x] v7.5 (TiDB 7.5 versions)
  • [x] v7.4 (TiDB 7.4 versions)
  • [x] v7.1 (TiDB 7.1 versions)
  • [x] v6.5 (TiDB 6.5 versions)
  • [x] v6.1 (TiDB 6.1 versions)
  • [x] v5.4 (TiDB 5.4 versions)
  • [x] v5.3 (TiDB 5.3 versions)
  • [x] v5.2 (TiDB 5.2 versions)
  • [x] v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

kennytm avatar Apr 09 '24 10:04 kennytm

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign dcalvin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Apr 09 '24 10:04 ti-chi-bot[bot]

/cc @chenmin1992

kennytm avatar Apr 09 '24 10:04 kennytm

@kennytm: GitHub didn't allow me to request PR reviews from the following users: chenmin1992.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @chenmin1992

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Apr 09 '24 10:04 ti-chi-bot[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Aug 02 '24 09:08 ti-chi-bot[bot]