docs-cn icon indicating copy to clipboard operation
docs-cn copied to clipboard

tikv: enable async-io by setting `raftstore.store-io-pool-size == 1` as default.

Open LykxSassinator opened this issue 1 year ago • 5 comments

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • [x] master (the latest development version)
  • [x] v8.0 (TiDB 8.0 versions)
  • [ ] v7.6 (TiDB 7.6 versions)
  • [ ] v7.5 (TiDB 7.5 versions)
  • [ ] v7.4 (TiDB 7.4 versions)
  • [ ] v7.1 (TiDB 7.1 versions)
  • [ ] v6.5 (TiDB 6.5 versions)
  • [ ] v6.1 (TiDB 6.1 versions)
  • [ ] v5.4 (TiDB 5.4 versions)
  • [ ] v5.3 (TiDB 5.3 versions)
  • [ ] v5.2 (TiDB 5.2 versions)
  • [ ] v5.1 (TiDB 5.1 versions)
  • [ ] v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s): issue: https://github.com/tikv/tikv/issues/16614, tikv-pr: https://github.com/tikv/tikv/pull/16615

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

LykxSassinator avatar Mar 07 '24 06:03 LykxSassinator

Hi @LykxSassinator. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Mar 07 '24 06:03 ti-chi-bot[bot]

/cc @qiancai

LykxSassinator avatar Mar 07 '24 06:03 LykxSassinator

Hi @LykxSassinator, may I know whether this change is introduced starting from TiDB v8.0?

qiancai avatar Mar 07 '24 06:03 qiancai

Hi @LykxSassinator, may I know whether this change is introduced starting from TiDB v8.0?

Yep

LykxSassinator avatar Mar 07 '24 08:03 LykxSassinator

/approve

easonn7 avatar Mar 12 '24 07:03 easonn7

/cc @glorv

LykxSassinator avatar Mar 14 '24 06:03 LykxSassinator

@glorv: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Mar 14 '24 06:03 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-03-12 10:03:17.748869501 +0000 UTC m=+766224.771115889: :ballot_box_with_check: agreed by qiancai.
  • 2024-03-18 08:14:32.924346596 +0000 UTC m=+1278099.946592969: :ballot_box_with_check: agreed by lilin90.

ti-chi-bot[bot] avatar Mar 18 '24 08:03 ti-chi-bot[bot]

/approve

qiancai avatar Mar 20 '24 07:03 qiancai

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Mar 20 '24 07:03 ti-chi-bot[bot]

/retest

qiancai avatar Mar 20 '24 07:03 qiancai