docs-cn icon indicating copy to clipboard operation
docs-cn copied to clipboard

Adjust the alert rule name from store to tikv

Open Oreoxmt opened this issue 1 year ago • 3 comments

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • [x] master (the latest development version)
  • [ ] v6.4 (TiDB 6.4 versions)
  • [x] v6.3 (TiDB 6.3 versions)
  • [x] v6.1 (TiDB 6.1 versions)
  • [x] v5.4 (TiDB 5.4 versions)
  • [ ] v5.3 (TiDB 5.3 versions)
  • [ ] v5.2 (TiDB 5.2 versions)
  • [ ] v5.1 (TiDB 5.1 versions)
  • [ ] v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from: https://github.com/pingcap/docs/pull/10638
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

Oreoxmt avatar Oct 08 '22 03:10 Oreoxmt

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Oct 08 '22 03:10 ti-chi-bot

Why change it? The store includes both TiKV and TiFlash

rleungx avatar Oct 08 '22 06:10 rleungx

Why change it? The store includes both TiKV and TiFlash

@rleungx The issue is https://github.com/pingcap/docs/issues/10626 "Alert name should be PD_cluster_down_tikv_nums rather than PD_cluster_down_store_nums". The alert rule in pd.rules.yml is PD_cluster_down_tikv_nums.

Oreoxmt avatar Oct 08 '22 06:10 Oreoxmt