dm icon indicating copy to clipboard operation
dm copied to clipboard

*: replace dumpling with tidb/dumpling

Open Little-Wallace opened this issue 3 years ago • 7 comments

What problem does this PR solve?

replace dumpling with tidb/dumpling. the repo github.com/pingcap/dumpling has been merged into github.com/pingcap/tidb

close https://github.com/pingcap/dm/issues/2259

What is changed and how it works?

Check List

Tests

  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the dm/dm-ansible
  • Need to be included in the release note

Little-Wallace avatar Oct 26 '21 03:10 Little-Wallace

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Oct 26 '21 03:10 ti-chi-bot

related to https://github.com/pingcap/dm/issues/2259

Ehco1996 avatar Oct 26 '21 05:10 Ehco1996

/merge

lichunzhu avatar Oct 26 '21 07:10 lichunzhu

This pull request has been accepted and is ready to merge.

Commit hash: ad92b60625077e1ae2b4bf6291721f6f7441269b

ti-chi-bot avatar Oct 26 '21 07:10 ti-chi-bot

@Little-Wallace: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Oct 26 '21 07:10 ti-chi-bot

/hold

lichunzhu avatar Oct 26 '21 07:10 lichunzhu

ping @Little-Wallace , dumpling is merged into tidb now.

glorv avatar Oct 26 '21 11:10 glorv