dm icon indicating copy to clipboard operation
dm copied to clipboard

The comments are in Chinese, there is a problem with log parsing

Open together-wang opened this issue 4 years ago • 2 comments

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error. The comments are in Chinese, and the following content can be seen from the log of dm-master image image

  2. What did you expect to see? The configuration file does not display comment information in the log

  3. What did you see instead? Chinese comments in dm-master log are not parsed [INFO] [server.go:1990] [payload="task:\"---\\nname: t1\\ntask-mode: all # all \\345\\215\\263\\345\\205\\210\\350\\277\\233\\350\\241\\214\\345\\205\\250\\351\\207\\217\\345\\220\\214\\346\\255\\245\\357\\274\\214\\345\\205\\250\\351\\207\\217\\345\\220\\214\\346\\255\\245\\345\\256\\214\\346\\210\\220\\345\\220\\216\\350\\207\\252\\345\\212\\250\\350\\277\\233\\350\\241\\214\\345\\242\\236\\351\\207\\217\\346\\225\\260\\346\\215\\256\\345\\220\\214\\346\\255\\245\\ncase-sensitive: true\\ntarget-database:\\n host: \\\"172.16.5.215\\\"\\n port: 4200\\n user: \\\"root\\\"\\n password: \\\"\\\"\\n\\nmysql-instances: \\n -\\n source-id: \\\"mysql-replica-01\\\"\\n block-allow-list: \\\"instance\\\"\\n mydumper-thread: 4\\n loader-thread: 16\\n syncer-thread: 16\\n\\n\\nblock-allow-list:\\n instance:\\n do-dbs: [\\\"lianxi\\\"]\\n\\n\" "] [request=CheckTask]

  4. Versions of the cluster [tidb@node127 dm]$ tiup dm display dm1

    • DM version (run dmctl -V or dm-worker -V or dm-master -V):

      Cluster version:    v2.0.1
      
    • Upstream MySQL/MariaDB server version:

      5.7.24
      
    • Downstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

      Release Version: v5.0.0-rc
      
    • How did you deploy DM: DM-Ansible or manually?

      TIUP
      
    • Other interesting information (system version, hardware config, etc):

  5. current status of DM cluster (execute query-status in dmctl)

  6. Operation logs

    • Please upload dm-worker.log for every DM-worker instance if possible
    • Please upload dm-master.log if possible
    • Other interesting logs
    • Output of dmctl's commands with problems
  7. Configuration of the cluster and the task

    • dm-worker.toml for every DM-worker instance if possible
    • dm-master.toml for DM-master if possible
    • task config, like task.yaml if possible
    • inventory.ini if deployed by DM-Ansible
  8. Screenshot/exported-PDF of Grafana dashboard or metrics' graph in Prometheus for DM if possible

together-wang avatar Mar 02 '21 03:03 together-wang

DM now prints the original content of file to log. If we modify the content before printing, there's a little chance that the modification will hide an error and make it harder to locate problems. So I prefer not to "does not display comment information".

Please close the issue if agreed

lance6716 avatar Apr 07 '21 05:04 lance6716

“prints the original content of file to log” is ok, but the problem is that the comments in the configuration file should not be in Chinese

sunzhaoyang avatar Oct 09 '21 03:10 sunzhaoyang