bl_iot_sdk icon indicating copy to clipboard operation
bl_iot_sdk copied to clipboard

Published 20 hours ago • verified publisher icon pine64

Fix GCC warnings

Open lupyuen opened this issue 3 years ago • 2 comments

This PR fixes the warnings in BL602 HAL generated by xpack-riscv-none-embed-gcc 8.3.0-2.3 when building for Mynewt OS. The warnings were due to buffer overflow, mismatched types, missing declarations and variables set but not used.

lupyuen avatar Dec 27 '20 06:12 lupyuen

These changes look good, thanks! Do you mind squashing the commits together? I'm generally in favor of as granular commits as possible, but one commit per line change seems a little excessive :) (I can also just merge with squash if you prefer that, but you won't have control over the final commit message if I do it that way.)

tchebb avatar Jan 01 '21 19:01 tchebb

Yes could you please merge with squash for me thanks! I haven't done squashing before and I'll probably mess it up 🙂

lupyuen avatar Jan 01 '21 23:01 lupyuen