floor
floor copied to clipboard
fallbackToDestructiveMigration is added
Hey there! I created a pull request to allow the fallbackToDestructiveMigration. Please check and review the request if it full fill the standards, and let me know if there's any thing missing or required to explain.
Codecov Report
Merging #473 (c343d71) into develop (362625d) will increase coverage by
0.50%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## develop #473 +/- ##
===========================================
+ Coverage 83.63% 84.13% +0.50%
===========================================
Files 69 10 -59
Lines 1741 208 -1533
===========================================
- Hits 1456 175 -1281
+ Misses 285 33 -252
Flag | Coverage Δ | |
---|---|---|
floor | 84.13% <ø> (+0.50%) |
:arrow_up: |
floor_generator | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 362625d...c343d71. Read the comment docs.
The new files and changes in the example directory add a lot of noise to the PR. Do we need them or could we just get rid of them? @Faiizii
@vitusortner The example (directory) was created with android support lib but flutter latest version using androidx lib for android. So, to support latest versions for both android and iOS, I deleted the both android and iOS folder and executed the flutter create .
command, and the flutter created the required files.
If you don't want them to be the part of the repo, we can go with old version of example directory
Whatever happened to this?
Whatever happened to this?
the owner did not accept the merge sadly.
Any update on this?
any update on this PR?
Hello @hm-tamim currently not plan to update and check it out next
I think fallbackToDestructiveMigration should be managed by a config option during database initialization (not from generated code). It makes it easy to manage, just like it works in the Room Persistence library. The current implementation is quite outdated and contains a lot of noise unrelated to the implementation of the feature. If you need this functionality please use this fork