floor icon indicating copy to clipboard operation
floor copied to clipboard

fallbackToDestructiveMigration is added

Open Faiizii opened this issue 4 years ago • 5 comments

Hey there! I created a pull request to allow the fallbackToDestructiveMigration. Please check and review the request if it full fill the standards, and let me know if there's any thing missing or required to explain.

Faiizii avatar Jan 05 '21 08:01 Faiizii

Codecov Report

Merging #473 (c343d71) into develop (362625d) will increase coverage by 0.50%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #473      +/-   ##
===========================================
+ Coverage    83.63%   84.13%   +0.50%     
===========================================
  Files           69       10      -59     
  Lines         1741      208    -1533     
===========================================
- Hits          1456      175    -1281     
+ Misses         285       33     -252     
Flag Coverage Δ
floor 84.13% <ø> (+0.50%) :arrow_up:
floor_generator ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lib/processor/error/queryable_processor_error.dart
...enerator/lib/writer/transaction_method_writer.dart
...tor/lib/misc/extension/set_equality_extension.dart
...loor_generator/lib/processor/entity_processor.dart
floor_generator/lib/value_object/view.dart
floor_generator/lib/processor/view_processor.dart
..._generator/lib/writer/database_builder_writer.dart
floor_generator/lib/writer/dao_writer.dart
...oor_generator/lib/writer/update_method_writer.dart
...ator/lib/misc/extension/dart_object_extension.dart
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 362625d...c343d71. Read the comment docs.

codecov[bot] avatar Jan 05 '21 08:01 codecov[bot]

The new files and changes in the example directory add a lot of noise to the PR. Do we need them or could we just get rid of them? @Faiizii

vitusortner avatar Jan 05 '21 18:01 vitusortner

@vitusortner The example (directory) was created with android support lib but flutter latest version using androidx lib for android. So, to support latest versions for both android and iOS, I deleted the both android and iOS folder and executed the flutter create . command, and the flutter created the required files. If you don't want them to be the part of the repo, we can go with old version of example directory

Faiizii avatar Jan 06 '21 05:01 Faiizii

Whatever happened to this?

wamaeb avatar Apr 11 '21 14:04 wamaeb

Whatever happened to this?

the owner did not accept the merge sadly.

Faiizii avatar Apr 19 '21 07:04 Faiizii

Any update on this?

hm-tamim avatar Nov 16 '22 17:11 hm-tamim

any update on this PR?

hm-tamim avatar Dec 29 '22 17:12 hm-tamim

Hello @hm-tamim currently not plan to update and check it out next

dkaera avatar Dec 29 '22 17:12 dkaera

I think fallbackToDestructiveMigration should be managed by a config option during database initialization (not from generated code). It makes it easy to manage, just like it works in the Room Persistence library. The current implementation is quite outdated and contains a lot of noise unrelated to the implementation of the feature. If you need this functionality please use this fork

dkaera avatar Jan 04 '23 10:01 dkaera