symposion icon indicating copy to clipboard operation
symposion copied to clipboard

Published 20 hours ago • verified publisher icon pinax

Make score computation at the python level

Open codersquid opened this issue 9 years ago • 3 comments

euroscipy/symposion has a couple of changes, and I'm opening issues for them. I don't know if this change fixes a problem (the other one did). https://github.com/euroscipy/symposion/commit/112123b54871d4fb925e521dfab1135db961bc5c

codersquid avatar May 14 '15 17:05 codersquid

@codersquid thank you for the report! Can you provide more details about why we need to ditch ProposalScoreExpression in favor of the Python version?

brosner avatar May 15 '15 14:05 brosner

@brosner Hi, I haven't actually looked in to the commit from @pdebuyl. I opened this issue since they had fixed something in one of the other commits, and I don't want to any of their other fixes to get lost. This change may just be a preference versus a fix. I've been hoping for some time to dig in to it.

codersquid avatar May 27 '15 21:05 codersquid

This part of the code was broken for EuroSciPy 2014. I didn't explain the bug in the commit message which is a bit annoying in retrospect.

From memory, I can think of two causes:

  • The Decimal module complained with an error.
  • The sql request refused to execute.

As I couldn't fix those problems, I saw the Python way as simpler and more robust.

pdebuyl avatar May 28 '15 08:05 pdebuyl