pinax-teams icon indicating copy to clipboard operation
pinax-teams copied to clipboard

WIP: add the ability to nest teams

Open jacobwegner opened this issue 8 years ago • 3 comments

Adds the ability to nest Teams.

Remaining:

  • [ ] Standardize convenience methods for ancestors and descendants.
  • [ ] Document new templates and add to the appropriate starter project.

For further discussion:

  • [ ] Should nesting be supported / the parent relation applied to SimpleTeam as well as Team? (see #25)
  • [ ] Is there a better way to handle slug creation on child teams?
  • [ ] Are there more performant ways to resolve get_root_team and ancestors using the ORM?
  • [ ] Do we allow for "implicit" memberships of teams beneath a parent (see Team.for_user).
  • [ ] Related to above, do we enforce a single membership for a user across a Team and its descendants/ancestors?

Comments/Gripes

  • [ ] Slug building off of parent pks (versus parent slugs)
    • Why not use the slugs (database limitations)
  • [ ] Prevent a team from being an ancestor
  • [ ] Team methods should reference self

jacobwegner avatar Mar 01 '16 16:03 jacobwegner

cc: @jtauber and @gregnewman

jacobwegner avatar Mar 10 '16 16:03 jacobwegner

cf #2

jacobwegner avatar Sep 11 '17 15:09 jacobwegner

Coverage Status

Coverage decreased (-1.5%) to 48.429% when pulling f25b1e42d84d56e09aee0c33f5d87bab1773d7b9 on jacobwegner:add-nested-teams into 96a72ec9dc8b3210edef18ab098df7211664ee6d on pinax:master.

coveralls avatar Sep 11 '17 21:09 coveralls