pinax-stripe-light
pinax-stripe-light copied to clipboard
fix charges/invoices listing by using stripe API
What's this PR do?
As described in #623 invoices
is no longer available in the pulled stripe customer data, thus pulling invoices list from the stripe API separately with customer id. Suggested by @polski-g in his comment: https://github.com/pinax/pinax-stripe/issues/623#issuecomment-455814540
Same goes for charges
as noted by the user in the comment.
Any background context you want to provide?
What ticket or issue # does this fix?
Closes #623
Definition of Done (check if considered and/or addressed):
- [x] Are all backwards incompatible changes documented in this PR?
- [x] Have all new dependencies been documented in this PR?
- [x] Has the appropriate documentation been updated (if applicable)?
- [x] Have you written tests to prove this change works (if applicable)?
I see no backwards incompatible changes that should be documented in this PR.
Codecov Report
Merging #630 into master will decrease coverage by
0.2%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #630 +/- ##
========================================
- Coverage 99.21% 99% -0.21%
========================================
Files 33 33
Lines 1911 1911
Branches 175 175
========================================
- Hits 1896 1892 -4
- Misses 7 9 +2
- Partials 8 10 +2
Flag | Coverage Δ | |
---|---|---|
#py27dj110 | 98.69% <0%> (-0.21%) |
:arrow_down: |
#py27dj111 | 98.69% <0%> (-0.21%) |
:arrow_down: |
#py27dj18 | 98.95% <0%> (-0.21%) |
:arrow_down: |
#py34dj110 | 98.69% <0%> (-0.21%) |
:arrow_down: |
#py34dj111 | 98.69% <0%> (-0.21%) |
:arrow_down: |
#py34dj18 | 98.95% <0%> (-0.21%) |
:arrow_down: |
#py34dj20 | 98.69% <0%> (-0.21%) |
:arrow_down: |
#py35dj110 | 98.69% <0%> (-0.21%) |
:arrow_down: |
#py35dj111 | 98.69% <0%> (-0.21%) |
:arrow_down: |
#py35dj18 | 98.95% <0%> (-0.21%) |
:arrow_down: |
#py35dj20 | 98.69% <0%> (-0.21%) |
:arrow_down: |
#py36dj111 | 98.69% <0%> (-0.21%) |
:arrow_down: |
#py36dj20 | 98.69% <0%> (-0.21%) |
:arrow_down: |
#py36dj20psql | 98.69% <0%> (-0.21%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
pinax/stripe/actions/invoices.py | 96.87% <0%> (-3.13%) |
:arrow_down: |
pinax/stripe/actions/charges.py | 93.33% <0%> (-2.23%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0005850...c818638. Read the comment docs.
I had attempted to fix the invoices method removal (in https://github.com/pinax/pinax-stripe/pull/622), but didn't know about the auto_paging_iter
method. I updated my PR to use that, but keep the code coverage the same.