pinax-notifications icon indicating copy to clipboard operation
pinax-notifications copied to clipboard

Published 20 hours ago • verified publisher icon pinax

make medium use a label as identifier

Open sherzberg opened this issue 10 years ago • 7 comments

fixes #21 this commit uses the backends label from NOTIFICATION_BACKENDS setting for easier to rearrange backends

for upgrades, you may have to write a custom alter statement to turn integers into varchars and then change the labels in your NOTIFICATION_BACKENDS to the string equivalent of the order

sherzberg avatar Aug 27 '14 16:08 sherzberg

Coverage Status

Coverage remained the same when pulling b832c3fa92ce05db15d05e82b43e75abc0bf9b19 on sherzberg:medium_id-is-label into 6782099acf104803185172b046a2ae1ad4e4c3cd on pinax:master.

coveralls avatar Aug 27 '14 16:08 coveralls

@sherzberg I actually like this change. Sorry for not merging it sooner.

paltman avatar Jun 19 '15 03:06 paltman

@sherzberg i'll try to update it and get it merged but if you could do me a favor and rebase your branch to get it updated so that I can merge it through GitHub it might make things faster. Thanks.

paltman avatar Jun 19 '15 03:06 paltman

@paltman cool! i rebased and had to fix a few conflicts. tests seem to pass locally on python 2.7 and django 1.7-1.8. I dont have python 3 setup on my home machine, so just waiting to see if the the travis build works out ok.

sherzberg avatar Jun 19 '15 04:06 sherzberg

@paltman Can this be merged?

ossanna16 avatar Dec 22 '15 15:12 ossanna16

@sherzberg i tested this PR with python3 and it works.. hope it gets merged sometime

psychok7 avatar Nov 29 '16 18:11 psychok7

@paltman @ossanna16 can this be merged?

psychok7 avatar Dec 07 '16 23:12 psychok7