django-mailer icon indicating copy to clipboard operation
django-mailer copied to clipboard

fix for expected str instance, NoneType found

Open ebdavison opened this issue 3 years ago • 0 comments

Closes: #149

Error encountered:

  File "/home/otcomm/otcomm/otcommenv/lib/python3.9/site-packages/mailer/engine.py", line 191, in send_all
    ", ".join(message.to_addresses))
TypeError: sequence item 1: expected str instance, NoneType found

Changes proposed in this PR:

  • fix situation where email address is None when submitted from Django view to django-mailer

Tips for an ideal PR

  • You have read our Code of Conduct: https://github.com/pinax/.github/blob/master/CODE_OF_CONDUCT.md
  • You have read our Contributing info: https://github.com/pinax/.github/blob/master/CONTRIBUTING.md
  • The PR is atomic
  • Unit tests have been updated/added, if needed
  • App version number has been updated in setup.py (Pinax uses SemVer)
  • Change Log has been updated
  • You have added your name to the AUTHORS file

ebdavison avatar Sep 15 '22 20:09 ebdavison