vdirsyncer icon indicating copy to clipboard operation
vdirsyncer copied to clipboard

Published 20 hours ago • verified publisher icon pimutils

don't normalize paths in expand_path

Open Witcher01 opened this issue 10 months ago • 6 comments

Remove normalizing paths in "expand_path" and expand environment variables. Paths don't need to be normalized, but doing this on non-path parameters (i.e. URLs) might cause bugs.

Reported-by: s-hamann Closes: https://github.com/pimutils/vdirsyncer/issues/1021

Witcher01 avatar Apr 15 '24 12:04 Witcher01

I'd have to recall why we normalised paths in the first place. The initial commit isn't very helpful: da8bba89de3baf26e45f7c70761326277d7532ea But I have a vague impression that it makes a difference in some situations (e.g.: when a user-provided path is compared with an internally-generated path maybe?).

But yeah, we shouldn't normalise paths on URLs, that's outright wrong.

WhyNotHugo avatar Apr 17 '24 15:04 WhyNotHugo

Looks like the readthedocs job is preventing this PR from being merged? It's saying the .readthedocs.yaml file can't be found in the repository, which I don't see on main either.

Would like to see this merged as I am also running into this issue.

Shadow53 avatar Sep 28 '24 05:09 Shadow53