todoman icon indicating copy to clipboard operation
todoman copied to clipboard

Add cli for description

Open AnubhaAgrawal opened this issue 7 years ago • 4 comments

Solve #240 for description

AnubhaAgrawal avatar Jun 18 '17 09:06 AnubhaAgrawal

Please tell me that there is any problem in test_edit_description.

AnubhaAgrawal avatar Jun 18 '17 18:06 AnubhaAgrawal

can you please tell me where should I add these tests.( from test_model.py or test_cli.py)

On Tue, Jun 20, 2017 at 2:44 PM, Hugo Osvaldo Barrera < [email protected]> wrote:

@hobarrera commented on this pull request.

In todoman/cli.py https://github.com/pimutils/todoman/pull/259#discussion_r123062013:

@@ -466,6 +468,8 @@ def move(ctx, list, ids): @cli.command() @pass_ctx @click.argument('lists', nargs=-1, callback=_validate_lists_param) [email protected]('--description',

This flag was used here https://github.com/pimutils/todoman/pull/259/commits/09fcd2177af47abaabf3ab67973e0918ad73f38b#diff-d7b704f0d282081b24d6d106d9ea528fL656. By deleting that bit of code, this flag is now unused and ignored.

My initial comment on that related bit of code was that there were no tests for it (though the code itself seemed fine). Basically, that would be a test that uses runner with 'list', '--description'.

You can either remove the flag (now unused), or undelete that code and add tests for it (I'm very much prefer the latter, of course. 🙂 ).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pimutils/todoman/pull/259#discussion_r123062013, or mute the thread https://github.com/notifications/unsubscribe-auth/AXknkfySDlmU5I95-bV5tf0Pn-kKJeFwks5sGBMZgaJpZM4N9dDs .

-- Anubha Agrawal, Sophomore year B.tech, Computer Science Department Zakir Hussain College of Engineering & Technology, AMU

AnubhaAgrawal avatar Jun 21 '17 17:06 AnubhaAgrawal

can you please tell me that is any other change is required??

AnubhaAgrawal avatar Jun 25 '17 10:06 AnubhaAgrawal

Looks like this comment hasn't been addressed yet.

WhyNotHugo avatar Jun 25 '17 20:06 WhyNotHugo