khal icon indicating copy to clipboard operation
khal copied to clipboard

Replace tz.localize with date.replace

Open rootandroo opened this issue 1 year ago • 1 comments
trafficstars

Resubmitted PR without syntax changes https://github.com/pimutils/khal/pull/1362

rootandroo avatar Oct 12 '24 14:10 rootandroo

Tests don't pass; we still rely on other pytz-specific attributes.

WhyNotHugo avatar Oct 12 '24 17:10 WhyNotHugo

I have tried to address that in #1364.

icalendar exposes a use_pytz() and I think it's safer and less intrusive. When running the tests (and also when running for real khal!) I have seen several problems due unavailability of icalendar.windows_to_olson and I've fixed that too.

All the tests now passes for me with #1364.

I think that PR can obsolete/close this one if it looks good to you!

Thank you!

iamleot avatar Oct 31 '24 13:10 iamleot