notes icon indicating copy to clipboard operation
notes copied to clipboard

invoke default file manager when `notes o` is invoked.

Open rmNULL opened this issue 6 years ago • 3 comments

Fixes

Fixes #58 #57 Closes #58 #57

Checklist

  • [x] I have made a change to this repository, be it functionality, testing, documentation, spelling, or grammar.
  • [x] I updated my branch with the master branch.
  • [ ] I have added the necessary testing to prove my fix is effective/my feature works (or I did not modify functionality).
  • [ ] I have added necessary documentation about the functionality in an appropriate .md file.
  • [ ] I have appropriately commented any code I have modified

Short description of what this PR does:

  • for Feedback ...

rmNULL avatar Apr 09 '18 16:04 rmNULL

Have you added tests to address the fix?

primis avatar Apr 16 '18 22:04 primis

@primis nope, I have problem running bats on my system.

rmNULL avatar Apr 17 '18 06:04 rmNULL

I noticed this option and that the open command is problematic last night.

I think it might be easier to set a config file variable with a default value that the user can override.

Maybe: FILE_MAN=open and then open the directory with: $FILE_MAN $notes_directory

Add some documentation and let the user decide what kind of command-line or gui file manager he wants to use for this.

eshapard avatar May 20 '21 22:05 eshapard