pimcore icon indicating copy to clipboard operation
pimcore copied to clipboard

[Feature][DataObject] Add possibility to download asset in relations

Open dpfahlbusch opened this issue 2 years ago • 5 comments

Changes in this pull request

Resolves #7633

Additional info

dpfahlbusch avatar Sep 13 '22 20:09 dpfahlbusch

Review Checklist

  • [x] Target branch (10.5 for bug fixes, others 11.x)
  • [ ] Tests (if it's testable code, there should be a test for it - get help)
  • [ ] Docs (every functionality needs to be documented, see here)
  • [ ] Migration incl. install.sql (e.g. if the database schema changes, ...)
  • [ ] Upgrade notes (deprecations, important information, migration hints, ...)
  • [x] Label
  • [x] Milestone

github-actions[bot] avatar Sep 13 '22 20:09 github-actions[bot]

I'm wondering if that is really a very common use case ... maybe we should keep that configurable, or just provide the functionality in the context menu? Just thinking, because we actually have already quite some buttons there 😉

brusch avatar Sep 15 '22 09:09 brusch

You mean adding a new checkbox in classconfig for relations ("allow inline download" or something like that)? :)

dpfahlbusch avatar Sep 15 '22 09:09 dpfahlbusch

Yeah, something like that. Or maybe we could even think about a more generic approach where you can configure the available buttons incl. adding your own buttons (or bundles) - which is then similar to use in all data-types? 🤔

brusch avatar Sep 15 '22 10:09 brusch

So I would say: In a first step I will make the buttons configurable (all of them or only a few? 🤔 ) And then in a followup we can make it generic :)

dpfahlbusch avatar Sep 18 '22 18:09 dpfahlbusch

@dpfahlbusch Could you please fix the conflicts. Thanks

robertSt7 avatar Oct 07 '22 10:10 robertSt7

@robertSt7 done :)

dpfahlbusch avatar Oct 07 '22 10:10 dpfahlbusch

@dpfahlbusch Could you please merge 11.x again in your branch? Thanks :)

robertSt7 avatar Oct 10 '22 08:10 robertSt7

@dpfahlbusch Thanks a lot :)

robertSt7 avatar Oct 10 '22 10:10 robertSt7