pimcore
pimcore copied to clipboard
[Feature][DataObject] Add possibility to download asset in relations
Changes in this pull request
Resolves #7633
Additional info
Review Checklist
- [x] Target branch (
10.5
for bug fixes, others11.x
) - [ ] Tests (if it's testable code, there should be a test for it - get help)
- [ ] Docs (every functionality needs to be documented, see here)
- [ ] Migration incl.
install.sql
(e.g. if the database schema changes, ...) - [ ] Upgrade notes (deprecations, important information, migration hints, ...)
- [x] Label
- [x] Milestone
I'm wondering if that is really a very common use case ... maybe we should keep that configurable, or just provide the functionality in the context menu? Just thinking, because we actually have already quite some buttons there 😉
You mean adding a new checkbox in classconfig for relations ("allow inline download" or something like that)? :)
Yeah, something like that. Or maybe we could even think about a more generic approach where you can configure the available buttons incl. adding your own buttons (or bundles) - which is then similar to use in all data-types? 🤔
So I would say: In a first step I will make the buttons configurable (all of them or only a few? 🤔 ) And then in a followup we can make it generic :)
@dpfahlbusch Could you please fix the conflicts. Thanks
@robertSt7 done :)
@dpfahlbusch Could you please merge 11.x again in your branch? Thanks :)
@dpfahlbusch Thanks a lot :)