data-hub icon indicating copy to clipboard operation
data-hub copied to clipboard

[Bug]: labels get lowercased

Open dkarlovi opened this issue 11 months ago • 4 comments

Expected behavior

The labeled field is exported exactly like the label.

Actual behavior

The labeled field is lowercased.

Steps to reproduce

  1. Create a field like so
                                -
                                    isOperator: true
                                    attributes:
                                        label: Image
                                        type: operator
                                        class: assets
                                        children:
                                            -
                                                isOperator: false
                                                attributes:
                                                    label: 'Category Image'
                                                    type: value
                                                    class: DefaultValue
                                                    attribute: image
                                                    dataType: image
                                                    children: {  }
  1. create a query like so
getProductCategoryListing {edges {node {id, Image{id, fullpath, url}}}}
  1. get error
GraphQL query failed: Cannot query field "Image" on type "object_ProductCategory". Did you mean "image" or "tags"?
  1. try with lowercase label
getProductCategoryListing {edges {node {id, image{id, fullpath, url}}}}
  1. it works like that

dkarlovi avatar Mar 27 '24 10:03 dkarlovi

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

github-actions[bot] avatar Apr 17 '24 07:04 github-actions[bot]

@dkarlovi I created a PR: https://github.com/pimcore/data-hub/pull/853 Can you test it?

blankse avatar Apr 22 '24 17:04 blankse

@blankse I will test it during the day, thanks.

dkarlovi avatar Apr 24 '24 09:04 dkarlovi

@blankse I can confirm this works correctly! :rocket:

dkarlovi avatar Apr 25 '24 08:04 dkarlovi

fixed with: https://github.com/pimcore/data-hub/pull/853

Corepex avatar May 17 '24 07:05 Corepex