data-hub icon indicating copy to clipboard operation
data-hub copied to clipboard

[Bug]: Permission check in save hook does not work outside of admin context

Open markus-moser opened this issue 11 months ago • 1 comments

Expected behavior

It should be possible to rename data object/folders outside of the admin context when data hub workspaces are involved.

Actual behavior

This exception is triggered:

https://github.com/pimcore/data-hub/blob/e66308aaafb34969e72d81423d427d95f8e36d98/src/Configuration.php#L235

The reason is that isAllowed() does not work without a logged in Pimcore user or in the CLI context:

https://github.com/pimcore/data-hub/blob/e66308aaafb34969e72d81423d427d95f8e36d98/src/Configuration.php#L439

But the DataChangeListener tries to execute this save() method when the folder get's renamed outside of the admin context (for example in the portal engine)

Steps to reproduce

  1. Create a asset folder
  2. Create a data hub workspace config with this folder
  3. Create a test controller action outside of admin context and try to change the filename of the asset folder.

markus-moser avatar Feb 27 '24 15:02 markus-moser