data-hub icon indicating copy to clipboard operation
data-hub copied to clipboard

Crop Image

Open do-web opened this issue 5 years ago • 8 comments

If i crop an image then the image in graphql output is not cropped. I receive only the crop data in graphql.

Bildschirmfoto 2021-02-12 um 17 53 04

do-web avatar Feb 12 '21 16:02 do-web

Hi @do-web , could you paste a request sample which I could use directly on the demo instance for investigations?

weisswurstkanone avatar Feb 15 '21 09:02 weisswurstkanone

Image fullpath and/or resolutions do not contain the cropped image.

{
  getImageElement(id: 123) {
    image {
      crop {
        cropTop
        cropLeft
        cropHeight
        cropWidth
      }
      
      image {
        fullpath
        filename
        
        resolutions(thumbnail: "ImageTeaser", types: [1, 2]) {
          url 
          resolution
        }
      }
    }
  }
}

do-web avatar Feb 15 '21 09:02 do-web

  crop {
    cropTop
    cropLeft
    cropHeight
    cropWidth
  }

provides some "dynamic" cropping values, but as far as I see it you also provide a thumbnail name.

What would be the expectation?

weisswurstkanone avatar Feb 15 '21 14:02 weisswurstkanone

That the images are already output cropped.

do-web avatar Feb 15 '21 14:02 do-web

Hello @julmot , seems that this got broken, at least with error reporting set to E_ALL. Could you please have a look if you find some thing. See https://github.com/pimcore/data-hub/pull/221

weisswurstkanone avatar Feb 15 '21 15:02 weisswurstkanone

Sorry, we don't have time to look into this at the moment.

julkue avatar Feb 16 '21 09:02 julkue

@julmot 🏓 what about now ? 😄

weisswurstkanone avatar Aug 23 '21 12:08 weisswurstkanone

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

github-actions[bot] avatar Jan 21 '24 07:01 github-actions[bot]