customer-data-framework icon indicating copy to clipboard operation
customer-data-framework copied to clipboard

PHP 8.3 Support

Open blankse opened this issue 11 months ago • 2 comments

See https://github.com/pimcore/pimcore/pull/16589

Requires https://github.com/pimcore/personalization-bundle/pull/66

blankse avatar Feb 29 '24 08:02 blankse

@blankse since https://github.com/pimcore/personalization-bundle/pull/66 and https://github.com/pimcore/pimcore/pull/16589 are merged, what's needed to get this merged as well?

limenet avatar Apr 18 '24 10:04 limenet

@limenet The 1.1.0 release in pimcore/personalization-bundle, because the tests only loads releases.

blankse avatar Apr 18 '24 10:04 blankse

@blankse could you please temporary change to require the 1.x-dev branch of personalization bundle to let the test run again? I am confident that it would be green but just to be sure 😄 Then i will just merge this, i am then also proceeding on merging https://github.com/pimcore/demo/pull/568 which led me here

kingjia90 avatar Jun 11 '24 12:06 kingjia90

@kingjia90 This is not enough for the demo repository. You also need https://github.com/pimcore/ecommerce-framework-bundle/pull/164 https://github.com/pimcore/data-hub/pull/840

blankse avatar Jun 11 '24 12:06 blankse

Ahh right, then it's worth to merge and test near the minor releases day otherwise the master branch would be still reporting false negative tests, it shouldn't take that much time by then, thank you anyways

kingjia90 avatar Jun 11 '24 12:06 kingjia90

@blankse you are simply too fast ;-) thx for fixing.

fashxp avatar Jun 18 '24 08:06 fashxp