pillarjs
Add support for transform option.
This is based on PR #69 by @peterbartels (see issue #71), but with conflicts resolved (and some typos in README.md fixed).
Adds a transform option, which allows the file stream to be transformed before piping it to res.
Switched to an older version of replacestream. Node.js 0.8 is happy now :)
Gotcha. I would much rather not use some ancient version, because that makes it hard for us to support new versions of Node.js. Can you find a module that is current? Otherwise, I mean, just write a transform stream in the test, because it's pretty simple.
Basically, just like any module, we always keep our dependencies up-to-date (they are slightly out of date right now, only because we haven't made a commit since those modules released new versions). If we find one of our dependencies no longer work with Node.js 0.8, for example, we replace it with something else that does. If we were to accept the PR as-is it would mean we would right away have a task to figure out what to replace the module with. Ideally, we don't really want to accept PRs that immediately put work on us, I'm sure you'll understand :)
Heh, no problem - I totally understand. I was just taking the easy way out by using the tests from the PR this was based on :smile:. I have an update that I'll push once it is cleaned up that uses a simple, inline replacement for replacestream.
Updated to use latest readable-stream and a trivial replaceStream implementation.
This is a cool feature! Is there any plan to integrate it soon to master? Thanks!
@dougwilson - are there any plans to take this change? I'm happy to do the work to resolve the conflicts that have arisen after 10 months of sitting stagnant, but only if there is a point.
I am going to take some liberty here and close this in favor of the much more deeply discussed https://github.com/pillarjs/send/pull/195 so that we can consolidate any conversation going forward. We are not going to try and land this feature soon, as we are focusing on the v5 push for express and this is not a breaking change, but I dont want to leave too many open PRs which are unlikely to see progress, especially when they are duplicates in many ways.
