router icon indicating copy to clipboard operation
router copied to clipboard

Promise support for `router.param`

Open jonchurch opened this issue 5 years ago • 1 comments

This is a reminder to myself (or anyone else) to implement this and give a smooth upgrade path to users of express-async-errors

https://github.com/davidbanham/express-async-errors/issues/28

jonchurch avatar Apr 17 '20 07:04 jonchurch

@dougwilson Can you assign this issue to me? I don't seem to have perms to do that in this repo.

jonchurch avatar Apr 17 '20 07:04 jonchurch

@jonchurch are you still interested in working on this? If you are, I would love to figure out how we can land holistic promise support before router@2 happens. I have this one in flight from a while back as well: https://github.com/pillarjs/router/pull/75

wesleytodd avatar Mar 16 '24 19:03 wesleytodd

Yeah Im interested. Need to dig up old stuff from the past but I had reached out to the maintainer of a popular package that monkey patched router with promise support.

If I can coordinate a release there to not crash when people use it with a native promise supporting router that would be great

jonchurch avatar Mar 16 '24 23:03 jonchurch

@wesleytodd oh this merged but the issue wasn't closed https://github.com/pillarjs/router/pull/92

jonchurch avatar Mar 17 '24 06:03 jonchurch