path-to-regexp icon indicating copy to clipboard operation
path-to-regexp copied to clipboard

Please add ESM export to v8

Open zoxon opened this issue 11 months ago • 3 comments

I try to update from v6 to v8 but have a problem with build and typescript when I try to use current CJS build I got [ERROR] exports is not defined

https://github.com/microsoft/TypeScript/issues/32934

zoxon avatar Jan 20 '25 09:01 zoxon

Can you share the full error you’re getting? I have used it successfully with Vite and that linked issue doesn’t appear to be related.

blakeembrey avatar Jan 22 '25 18:01 blakeembrey

I'm using it with astro. Astro build on vite

Here is the logs part releated to error

  vite:resolve 0.20ms path-to-regexp -> /Users/zoxon/app/node_modules/path-to-regexp/dist/index.js +1ms
  vite:resolve 0.20ms ufo -> /Users/zoxon/app/node_modules/ufo/dist/index.mjs +0ms
  vite:import-analysis 0.40ms [6 imports rewritten] src/core/routes/helpers.ts +2ms
  vite:transform 1.04ms /src/core/routes/helpers.ts +2ms
  vite:load 0.11ms [fs] ../../node_modules/path-to-regexp/dist/index.js +2ms
  vite:import-analysis 0.07ms [no imports] /Users/zoxon/app/node_modules/path-to-regexp/dist/index.js +1ms
  vite:transform 0.15ms [skipped] ../../node_modules/path-to-regexp/dist/index.js +1ms
  astro:vite Error when evaluating SSR module /Users/zoxon/app/src/pages/[...region]/[...lang]/market/[...ticker].astro:
  astro:vite |- ReferenceError: exports is not defined
  astro:vite     at eval (/Users/zoxon/app/node_modules/path-to-regexp/dist/index.js:4:23)
  astro:vite     at ESModulesEvaluator.runInlinedModule (file:///Users/zoxon/app/node_modules/astro/node_modules/vite/dist/node/module-runner.js:1057:6)
  astro:vite     at SSRCompatModuleRunner.directRequest (file:///Users/zoxon/app/node_modules/astro/node_modules/vite/dist/node/module-runner.js:1271:82)
  astro:vite     at SSRCompatModuleRunner.directRequest (file:///Users/zoxon/app/node_modules/astro/node_modules/vite/dist/node/chunks/dep-BJP6rrE_.js:30789:35)
  astro:vite     at SSRCompatModuleRunner.cachedRequest (file:///Users/zoxon/app/node_modules/astro/node_modules/vite/dist/node/module-runner.js:1166:28)
  astro:vite     at request (file:///Users/zoxon/app/node_modules/astro/node_modules/vite/dist/node/module-runner.js:1215:79)
  astro:vite     at async eval (/Users/zoxon/app/src/core/routes/helpers.ts:6:31)
  astro:vite     at async ESModulesEvaluator.runInlinedModule (file:///Users/zoxon/app/node_modules/astro/node_modules/vite/dist/node/module-runner.js:1049:5)
  astro:vite     at async SSRCompatModuleRunner.directRequest (file:///Users/zoxon/app/node_modules/astro/node_modules/vite/dist/node/module-runner.js:1271:61)
  astro:vite     at async SSRCompatModuleRunner.directRequest (file:///Users/zoxon/app/node_modules/astro/node_modules/vite/dist/node/chunks/dep-BJP6rrE_.js:30789:23)
  astro:vite  +0ms
08:55:27 [ERROR] exports is not defined
  Location:
    /Users/zoxon/app/Users/zoxon/app/node_modules/path-to-regexp/dist/index.js:4:23
  Stack trace:
    at eval (/Users/zoxon/app/node_modules/path-to-regexp/dist/index.js:4:23)
    at SSRCompatModuleRunner.directRequest (file:///Users/zoxon/app/node_modules/astro/node_modules/vite/dist/node/module-runner.js:1271:82)
    at SSRCompatModuleRunner.cachedRequest (file:///Users/zoxon/app/node_modules/astro/node_modules/vite/dist/node/module-runner.js:1166:28)
    at async eval (/Users/zoxon/app/src/core/routes/helpers.ts:5:1)
    at async SSRCompatModuleRunner.directRequest (file:///Users/zoxon/app/node_modules/astro/node_modules/vite/dist/node/module-runner.js:1271:61)
  vite:time 1003.67ms /api/market?secondary=Usd +0ms

zoxon avatar Jan 23 '25 03:01 zoxon

Hi @zoxon, I'm not sure if I can help you completely, but you can check out this repository of mine, where I got path-to-regex@8 to work. Maybe it can help you.

https://github.com/bjohansebas/playground-router

bjohansebas avatar Jan 23 '25 23:01 bjohansebas