path-to-regexp icon indicating copy to clipboard operation
path-to-regexp copied to clipboard

ci: add node versions from 17 to 22

Open inigomarquinez opened this issue 1 year ago • 2 comments

This PR adds node versions from 17 to 22 to the CI so the tests are run for all the different nodejs versions apart from version 16.

inigomarquinez avatar Apr 30 '24 09:04 inigomarquinez

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (28a5b27) to head (31d1c4c). Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #303   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          621       621           
  Branches       140       140           
=========================================
  Hits           621       621           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 30 '24 09:04 codecov[bot]

Why is this useful? The library doesn’t use any node.js features so testing every version seems like overkill. And I’ll have to manually increment the latest version now?

blakeembrey avatar Apr 30 '24 14:04 blakeembrey

Why is this useful? The library doesn’t use any node.js features so testing every version seems like overkill. And I’ll have to manually increment the latest version now?

I thought this modification would be convenient for consistency with other repositories in the organisation, in which the ci runs on an array of node versions from the original to the latest active one (see this or this), so that you can easily verify that there is no problem with any of the nodejs versions.

Anyway, feel free to discard the PR if you don't find it interesting.

inigomarquinez avatar May 05 '24 12:05 inigomarquinez

Happy to accept all the other version bumps, but I'd prefer to keep the node.js versions as-is - min version + max version tests only.

blakeembrey avatar May 14 '24 21:05 blakeembrey