finalhandler icon indicating copy to clipboard operation
finalhandler copied to clipboard

replace on-finished with stream.finished

Open bjohansebas opened this issue 8 months ago • 1 comments

on-finished can be replaced by finished, isFinished is still required for future maintainability

bjohansebas avatar Apr 21 '25 02:04 bjohansebas

I really like the direction of this change - using stream.finished is definitely a cleaner and more modern approach. However, I'd be in favor of implementing this improvement directly within the on-finished package and releasing it as a new major version.

This way, we can centralize the logic, maintain consistency for our packages that depend on on-finished, and allow consumers to benefit from the native stream.finished without having to refactor their own usage across different codebases.

Curious to hear your thoughts on this approach!

Phillip9587 avatar Apr 28 '25 10:04 Phillip9587

Closing since version 3 of on-finished is being worked on.

bjohansebas avatar Jul 12 '25 00:07 bjohansebas