finalhandler icon indicating copy to clipboard operation
finalhandler copied to clipboard

Develop

Open wesleytodd opened this issue 1 year ago • 2 comments

wesleytodd avatar Aug 31 '24 19:08 wesleytodd

@Phillip9587 @UlisesGascon I had opened this to make sure we didn't loose @dougwilson's work on this. I forgot about it until just now and realized maybe we could land some of this? Can y'all take a look and share your opinion on it?

wesleytodd avatar Mar 05 '25 14:03 wesleytodd

@wesleytodd Introducing the text/plain fallback response is a non-breaking change that can be integrated into the current v2 release line. However, adding the new message and stacktrace options while removing the existing env option is a breaking change in the current state, as it modifies the current options interface and could affect users relying on the env setting.

I suggest splitting the pull request into two separate ones to keep reviews focused:​

  • One PR focusing on the text/plain fallback response.

  • Another PR introducing the message and stacktrace options and deprecating the env option.

I will split them up and open 2 PRs so we can keep reviewing on the individual changes.

Phillip9587 avatar Mar 05 '25 16:03 Phillip9587

Somehow closed this when cleaning up stale branches. Opened again as #129

Phillip9587 avatar Dec 17 '25 16:12 Phillip9587