Microdown icon indicating copy to clipboard operation
Microdown copied to clipboard

ReferenceChecker should handled the inputFiles the same for the checkDir: than the checkProject:.

Open Ducasse opened this issue 1 year ago • 3 comments

Right now

  • checkProject: is looking for the transitive closure of the files via inputFile (using the fileCollector)
  • checkDirectory: does not look for the transitive closure and this is not good.

both checkProject: and checkDirectory: should have the same semantics.

We should add a test clearly showing that they is not difference once this problem is fixed.

Ducasse avatar Aug 03 '24 14:08 Ducasse

@melkiyasser

Ducasse avatar Aug 03 '24 14:08 Ducasse

checkProject: is basically looking for all the files it can reach starting from an input. When making checkDir: using the same logic with all the files in a directory, the worklist should be shared among all the files in checkDir: to avoid to treat files multiple times (it could happens if we have several files in the directory pointing a same inputFile for example).

Ducasse avatar Sep 05 '24 18:09 Ducasse

We should check the PR of Quentin because I have some doubts.

Ducasse avatar Oct 17 '24 15:10 Ducasse