Microdown icon indicating copy to clipboard operation
Microdown copied to clipboard

MicTextBlock substring: is a bad API

Open Ducasse opened this issue 3 years ago • 5 comments

It should be at least string:

Ducasse avatar Oct 25 '22 14:10 Ducasse

Is in the new parser which is currently getting a lot of tests

kasperosterbye avatar Oct 25 '22 14:10 kasperosterbye

actually it becomes bodyString - less generic

kasperosterbye avatar Oct 25 '22 14:10 kasperosterbye

Cool. We will just deprecated substring: and I will fix all the tests using '' (this is why I started to clean the dumper because I start to hate the string based assert.

Ducasse avatar Oct 25 '22 19:10 Ducasse

And I need to learn how to use the deprecated feature.

kasperosterbye avatar Oct 31 '22 05:10 kasperosterbye

easy like that

substrings: aString
    self deprecate: 'kjhkjhkj tranformWith: '`@rec substrings: `@arg' -> '`@rec body: `@arg'.
    self body: aString

Ducasse avatar Oct 31 '22 06:10 Ducasse