arctic icon indicating copy to clipboard operation
arctic copied to clipboard

impl soundcloud (v2 branch)

Open alii opened this issue 1 year ago • 1 comments

Don't merge this yet - haven't had a chance to test it

alii avatar Aug 22 '24 11:08 alii

Just wanted to note, this hasn't been updated yet as I'm waiting for API access from SoundCloud. The implementation is according to their documentation and other pkce implementations in arctic. I still wanted to test it first, of course.

alii avatar Sep 09 '24 12:09 alii

I'm also waiting on API access from SoundCloud. Took a look at your code while working on some other providers; tweaked it a little so I threw up a PR on your fork if you're interested: https://github.com/alii/arctic/pull/1

gmvi avatar Nov 10 '24 23:11 gmvi

What's the reason for closing this? No hard feelings 😅

alii avatar Dec 28 '24 02:12 alii

I think it's because I accidentally deleted the v2 brach. Can you change the PR target to main or v3?

pilcrowonpaper avatar Dec 28 '24 02:12 pilcrowonpaper

Would you prefer v3? Since this still needs testing anyway...

alii avatar Dec 28 '24 02:12 alii

yeah v3 would be better

pilcrowonpaper avatar Dec 28 '24 02:12 pilcrowonpaper

Lots of merge conflicts. will update/fix this soon

alii avatar Dec 28 '24 20:12 alii