arctic icon indicating copy to clipboard operation
arctic copied to clipboard

Feature request: Github App Provider

Open alex-way opened this issue 9 months ago • 1 comments

It seems like the GitHub provider is expecting/using the Oauth app type. However, Github are now recommending github apps to be used in favour of oauth apps: https://docs.github.com/en/enterprise-cloud@latest/apps/overview#github-apps-and-oauth-apps

Relevant documentation for generating a user access token: https://docs.github.com/en/enterprise-cloud@latest/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-user-access-token-for-a-github-app#using-the-device-flow-to-generate-a-user-access-token

alex-way avatar Apr 28 '24 13:04 alex-way

Are you referring to GitHub Apps or device code login?

pilcrowonpaper avatar May 01 '24 15:05 pilcrowonpaper

@pilcrowOnPaper I'd be interested in hearing how you think one should implement Oauth flow using a GitHub App (as opposed to a GitHub OAuth App)? Regular Oauth login, not device flow.

hunvreus avatar Aug 14 '24 01:08 hunvreus

Sorry, I'm a bit confused what needs to be done to support GitHub Apps? Doesn't it just use the same OAuth 2.0 flow with the same endpoints?

pilcrowonpaper avatar Aug 17 '24 00:08 pilcrowonpaper

Yes, I realized that 0.2 seconds after I posted this. It works the same for GitHub Apps and GitHub OAuth Apps.

hunvreus avatar Aug 17 '24 00:08 hunvreus

Closing this unless there's a change that needs to be done by us

pilcrowonpaper avatar Aug 17 '24 00:08 pilcrowonpaper

@pilcrowOnPaper Thanks for Lucia (and Arctic, and Oslo).

I switched my Next.js project over from Auth.js and find it a lot more straightforward.

hunvreus avatar Aug 17 '24 04:08 hunvreus