nils måsén
nils måsén
Confirmed as fixed in 0.10.6, closeable?
Sorry, I have been busy with work. There are some inconsistencies in the API that I need to look over, but it should mostly be done.
Every entry has it's own compression, but yeah, in theory it should be possible to support seeking when the current entry uses `Store` "compression".
There is a 1/256 chance of an invalid password not being detected, as the CRC that is used to check the password is a single byte: https://p1k.se/appnote.md#s616-decrypting-the-encryption-header To be clear,...
Yes, you are right, not sure how that happened. There should be getters and setters to access the internal `_stringCodec`, and perhaps the constructor should be public as well.
> IsUnicodeText = true gives same result as IsUnicodeText = false This is because it's only used for **creating** entries, not when reading. > No data is available for encoding...
Actually, I am going to reopen this, because the automatic encoding only works if ```cs Encoding.RegisterProvider(CodePagesEncodingProvider.Instance); ``` is called before any instance of `ZipCodec` has been accessed, and only on...
I don't really understand what this is supposed to accomplish... Running `Dummy(Array.Empty())` should just return `byte[0]`. In any case, the bug is probably caused by [this remark](https://learn.microsoft.com/en-us/dotnet/api/system.buffers.arraypool-1.rent?view=net-6.0#remarks). The array pool...
## Repro https://dotnetfiddle.net/Drl27x __Note__: Causes `System.ArgumentOutOfRangeException: Cannot be less than zero (Parameter 'value')` instead due to the garbage data being `0x8b`, but it's still caused by the same bug.
It's definitively caused by the re-use of a shared array pool array. The array is not zeroed, so when reading from an empty source it will treat the "garbage" data...