nils måsén

Results 390 comments of nils måsén

Regarding `ConfigureAwait`: > if you’re writing general-purpose library code, use ConfigureAwait(false) from https://devblogs.microsoft.com/dotnet/configureawait-faq/#when-should-i-use-configureawaitfalse

Good initiative. I basically did this and turned it off again because of the spamming, but we should set up a ignore list, including CA1303 (until we get localization).

Yeah, I don't see any problems with requiring VS 2019 for FxCop. If a need for this to change emerges then we could just disable or change this later, but...

No, that's probably due to something unexpected in the CI. Especially since it worked on the same platform, different config, and same config, different platform(s).

I'm thinking about how to best get this merged. The best thing to do is probably to just create a bulk commit/PR with most of the fixes done. This will...

I have not looked in to why certain constants where used for each level. One would assume that they should be the same as in zlib. A PR would be...

Couldn't you just set the `RootPath` to `"home/username"`?

This is probably a duplicate of #38 (how fitting). But that one only contains dead links and not a clear description. Closing it in favor of this one.

Gah. Github! Instead of using the number I actually typed, it auto-completed to the first search result that started with the number (413).